With our first shindig release just around the corner (branching has already happened), it was a now-or-never kind of moment to adjust the php code formatting style; And it turns out it's 'now' and not 'never' :)
The code format of php shindig and partuza has long been different from the java implementation, and this commit corrects that. In the end the fact that the majority of the contributors & contributions (Google, Plaxo, Globant) use & are used to this style of formatting was enough of a reason to take this leap and adjust the project(s), even though this will undoubtedly cause a fair amount of commit spam and goble up a fair bit of bandwidth in the short term, but it beats trying to force our major contributers to live with a different code style then their used too. Now a commit is nothing without documentation on what this new formatting is, so i've included a style guide: http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/style-guide.html and a Zend Studio formatting that you can import into it (if your not using Zend Studio for Eclipse, you consider using it): http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/style-conventions.xml ps: The main changes are that 2 spaces are used for identation instead of a tab (which causes the huge --everything, ++everything part of the patch), and the function { is now on the same line instead of the next one, for the rest the code style is identical to what it was before. Again my appologies for the commit spam and confusion, but the good news is that this will never have to happen again :) -- Chris
