OK, but can you defend SHINDIG-759 as you just filed? Once the XStream code has been fixed, why should @ImplementedBy be removed? How does this patch make things better? IMO, it makes things *far* worse. Either a developer uses this new DefaultGuiceModule and DefaultOpenSocialObjectsModule or you don't. If the developer does, their life is unchanged. If the developer doesn't, their code breaks every time we add a new entry to one of these modules, which means their life is worse.
On Wed, Dec 3, 2008 at 4:29 PM, Henning P. Schmiedehausen <[EMAIL PROTECTED]> wrote: > Adam Winer <[EMAIL PROTECTED]> writes: > >>On Wed, Dec 3, 2008 at 2:12 PM, Kevin Brown <[EMAIL PROTECTED]> wrote: > >>> SocialApiGuiceModule is never usable for production, and it can't be for the >>> simple fact that there's no way to reason about the data store of a given >>> container. > >>There's no reason we can't provide a Module that implements the parts >>that have sane default bindings. And putting the sample container >>dependencies in a module in o.a.s.social.core.config is way wrong. >>Ditto the abuse of @ImplementedBy to tie PersonService, etc. to the >>JsonDbOpensocialService. All that should be in a separate >>SampleContainerModule to make it crystal clear to developers the >>interfaces they absolutely have to bind for a real, production >>container. > > +1. > > Ciao > Henning > > -- > Henning P. Schmiedehausen - Palo Alto, California, U.S.A. > [EMAIL PROTECTED] "We're Germans and we use Unix. > [EMAIL PROTECTED] That's a combination of two demographic groups > known to have no sense of humour whatsoever." > -- Hanno Mueller, de.comp.os.unix.programming >
