:D looks like a good trade off
ropu On Thu, Dec 4, 2008 at 3:15 PM, Chris Chabot <[EMAIL PROTECTED]> wrote: > there, not being on an iPhone I was able to take a bit of a deeper look, > I've checked in a fix that limits the impact of this change somewhat: It > now > checks to see if there's a Content-Type: application/x-shockwave-flash > header, and if so *only then* does it skip the content disposition header. > > On Thu, Dec 4, 2008 at 3:06 PM, Chris Chabot <[EMAIL PROTECTED]> wrote: > > > Yep we are aware of it and this fix has been in java for a while > > already, without it any app that uses flash, like budypoke and all > > others too, break.. Something to do a new flash versions I think, I'm > > sure you can find re old thread in our mail archives; unavoidable > > unfortunately > > > > > > On 12/4/08, Ropu <[EMAIL PROTECTED]> wrote: > > > Chris, just be careful with this patch! > > > > > > since doing that you are opening a free proxy! > > > > > > A Phishing server may result from this change... > > > > > > Please double check if what is braking the Flash is the > type:attachment, > > or > > > the filename.txt, so we can leave at least one of those protections > > > > > > ropu > > > > > > On Wed, Dec 3, 2008 at 7:40 AM, <[EMAIL PROTECTED]> wrote: > > > > > >> Author: chabotc > > >> Date: Wed Dec 3 01:40:45 2008 > > >> New Revision: 722822 > > >> > > >> URL: http://svn.apache.org/viewvc?rev=722822&view=rev > > >> Log: > > >> Removed the content disposition header that was breaking some versions > > of > > >> flash > > >> > > >> Modified: > > >> incubator/shindig/trunk/php/src/gadgets/ProxyHandler.php > > >> > > >> Modified: incubator/shindig/trunk/php/src/gadgets/ProxyHandler.php > > >> URL: > > >> > > > http://svn.apache.org/viewvc/incubator/shindig/trunk/php/src/gadgets/ProxyHandler.php?rev=722822&r1=722821&r2=722822&view=diff > > >> > > >> > > > ============================================================================== > > >> --- incubator/shindig/trunk/php/src/gadgets/ProxyHandler.php > (original) > > >> +++ incubator/shindig/trunk/php/src/gadgets/ProxyHandler.php Wed Dec > 3 > > >> 01:40:45 2008 > > >> @@ -273,8 +273,6 @@ > > >> $status = (int)$result->getHttpCode(); > > >> if ($status == 200) { > > >> $headers = explode("\n", $result->getResponseHeaders()); > > >> - // Send the file as attachment > > >> - $headers[] = 'Content-Disposition: attachment; filename=p.txt'; > > >> foreach ($headers as $header) { > > >> if (strpos($header, ':')) { > > >> $key = trim(substr($header, 0, strpos($header, ':'))); > > >> > > >> > > >> > > > > > > > > > -- > > > .-. --- .--. ..- > > > R o p u > > > > > > -- .-. --- .--. ..- R o p u
