Chico,
I am hoping to use the JPA project inside samples when I get a chance,
so patches will be very gratefully received, however you may find a
number of bugs since I haven't had time (yet) to get good unit test
coverage and fix anything.
Obviously you could do your own persistence layer, but it would be
good to share resources.
Ian
On 8 Dec 2008, at 17:21, chico charlesworth wrote:
I've been spending the last few days trying to get started on
integrating
shindig with a JPA persistence layer which is based on shindig-
samples. In
doing this, I've extended RestfulJsonPeopleTest to further test
PersonServiceDb, where I've just managed to get testGetPersonJson()
working
sucessfully, although I found a couple of bugs on the way (JIRA 769
and
770).
I've now moved on to trying to get
RestfulJsonPeopleTest.testGetPeople()
working, and I see the method implementation of
PersonServiceDb.getPeople()
references the following constants in PersonDb:
- JPQL_FINDALLPERSON, JPQL_FINDPERSON_BY_FRIENDS,
JPQL_FINDPERSON_BY_GROUP,
and JPQL_FINDPERSON.
All these constants are set to null in PersonDb, which makes me
believe that
there's still work to be done in this area.
As you can see I'm trying to reuse as much from the social-api and
samples
modules as I can, but I'm concerned that the samples code is not
really that
reliable at the moment, and that it's going to be very time
consuming to
make proper use of it. For example, the test coverage for
PersonServiceDb,
ActivityServiceDb and AppDataServiceDb is almost non-existent. Is
there any
ongoing efforts at the moment to improve the samples module, or
should I
consider moving away from samples all together and writing the
persistence
layer from scratch?
Cheers
Chico
