Jasvir, can you submit this through Jira? Feel free to reopen the original caja ticket and attach the patch below.

Thanks!

On Jan 14, 2009, at 9:32 AM, Jasvir Nagra wrote:

Upgrading the version to 3146 requires patching
features/opensocial-reference/container.js -- there was a change to
attachDocumentStub api. I am curious if EndToEndTests were green with this
commit?

Index: features/opensocial-reference/container.js
===================================================================
--- features/opensocial-reference/container.js    (revision 733149)
+++ features/opensocial-reference/container.js    (working copy)
@@ -554,9 +554,9 @@
  ___.getNewModuleHandler().setImports(imports);


-  attachDocumentStub('-g___', uriCallback, imports);
  var gadgetRoot = document.createElement('div');
  gadgetRoot.className = 'g___';
+  attachDocumentStub('-g___', uriCallback, imports, gadgetRoot);
  imports.htmlEmitter___ = new HtmlEmitter(gadgetRoot);
  document.body.appendChild(gadgetRoot);


On Tue, Jan 13, 2009 at 2:38 PM, <[email protected]> wrote:

Author: etnu
Date: Tue Jan 13 14:38:20 2009
New Revision: 734262

URL: http://svn.apache.org/viewvc?rev=734262&view=rev
Log:
Updating caja version for SHINDIG-843.


Modified:
  incubator/shindig/trunk/pom.xml

Modified: incubator/shindig/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/pom.xml?rev=734262&r1=734261&r2=734262&view=diff

= = = = = = = = = =====================================================================
--- incubator/shindig/trunk/pom.xml (original)
+++ incubator/shindig/trunk/pom.xml Tue Jan 13 14:38:20 2009
@@ -1146,7 +1146,7 @@
     <dependency>
       <groupId>caja</groupId>
       <artifactId>caja</artifactId>
-        <version>r3034</version>
+        <version>r3164</version>
       <scope>compile</scope>
     </dependency>
     <dependency>




Reply via email to