Hi Paul, Could you close this issue or comment on it?
Thanks Vincent 2009/1/13, [email protected] <[email protected]>: > Author: lindner > Date: Tue Jan 13 05:01:44 2009 > New Revision: 734119 > > URL: http://svn.apache.org/viewvc?rev=734119&view=rev > Log: > SHINDIG-842 | Patch from Henning Schmiedehausen | DataRequestHandler > confuses CREATE and UPDATE > > Modified: > > incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/DataRequestHandler.java > > Modified: > incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/DataRequestHandler.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/DataRequestHandler.java?rev=734119&r1=734118&r2=734119&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/DataRequestHandler.java > (original) > +++ > incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/DataRequestHandler.java > Tue Jan 13 05:01:44 2009 > @@ -30,8 +30,8 @@ > public abstract class DataRequestHandler { > > private static final Set<String> GET_SYNONYMS = ImmutableSet.of("get"); > - private static final Set<String> CREATE_SYNONYMS = ImmutableSet.of("put", > "create"); > - private static final Set<String> UPDATE_SYNONYMS = > ImmutableSet.of("post", "update"); > + private static final Set<String> CREATE_SYNONYMS = > ImmutableSet.of("post", "create"); > + private static final Set<String> UPDATE_SYNONYMS = ImmutableSet.of("put", > "update"); > private static final Set<String> DELETE_SYNONYMS = > ImmutableSet.of("delete"); > > public Future<?> handleItem(RequestItem request) { > @@ -44,9 +44,9 @@ > try { > if (GET_SYNONYMS.contains(operation)) { > responseItem = handleGet(request); > - } else if (UPDATE_SYNONYMS.contains(operation)) { > - responseItem = handlePost(request); > } else if (CREATE_SYNONYMS.contains(operation)) { > + responseItem = handlePost(request); > + } else if (UPDATE_SYNONYMS.contains(operation)) { > responseItem = handlePut(request); > } else if (DELETE_SYNONYMS.contains(operation)) { > responseItem = handleDelete(request); > > >
