http://codereview.appspot.com/14041/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java
(right):

http://codereview.appspot.com/14041/diff/1/2#newcode41
Line 41: public class CajaCssSanitizer {
I'm a little concerned about tying this too closely with Caja. This
effectively forces a caja dependency even on someone who doesn't want to
allow CSS. It should be possible to extract a CssSanitizer interface
from this.

http://codereview.appspot.com/14041/diff/1/2#newcode85
Line 85: + ((CssTree.Property) ancestorChain.node).getPropertyName());
INFO is probably too high a warning level here. FINE or lower seems to
make more sense. Otherwise this is just log spam for most gadgets.

http://codereview.appspot.com/14041/diff/1/10
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
(right):

http://codereview.appspot.com/14041/diff/1/10#newcode45
Line 45: public class CssRewriter {
The relationship between CssRewriter and CSSContentRewriter isn't
terribly clear (other than CSSContentRewriter implementing the
ContentRewriter interface). The naming is also inconsistent. Now seems
like a good time to clean that up.

http://codereview.appspot.com/14041/diff/1/10#newcode53
Line 53: private static final Pattern urlMatcher =
Is this necessary any longer?

http://codereview.appspot.com/14041

Reply via email to