Thanks for the comments.
http://codereview.appspot.com/14063/diff/3001/33 File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/SocialMarkupHtmlParser.java (right): http://codereview.appspot.com/14063/diff/3001/33#newcode59 Line 59: private class MarkupDocumentHandler extends DocumentHandler { On 2009/02/11 02:27:59, louiscryan wrote:
rename to SocialMarkupDocumentHander?
Done. http://codereview.appspot.com/14063/diff/3001/33#newcode86 Line 86: scanner.evaluateInputSource(scriptSource); On 2009/02/11 02:27:59, louiscryan wrote:
Its pretty cool that the scanner supports nested input sources :)
Enormously so. http://codereview.appspot.com/14063/diff/3001/33#newcode103 Line 103: scriptContent = new StringBuilder(); On 2009/02/11 02:27:59, louiscryan wrote:
a little wasteful, how about using a boolean to represent the state
and just
clearing on completion. If builder gets large thats alot of alloc.
Done. http://codereview.appspot.com/14063/diff/3001/27 File java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/PipelinedDataTest.java (right): http://codereview.appspot.com/14063/diff/3001/27#newcode231 Line 231: public void testBatching() throws Exception { On 2009/02/11 02:27:59, louiscryan wrote:
consider making this test cover a little more ground.. more than one round of batching, an entry with no dependents, a
dependency bound
into the initial context.
Wrote a couple more tests - one with two batches (including an initial dependency), one with a missing dependency so no batches can run. Also verified that os-data sections were deleted (or not, depending on the test). http://codereview.appspot.com/14063
