http://codereview.appspot.com/14084/diff/1/8 File java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java (right):
http://codereview.appspot.com/14084/diff/1/8#newcode90 Line 90: Logger.getLogger("org.apache.shindig").log(Level.SEVERE, ee.getCause().getMessage(), ee); On 2009/02/12 16:32:35, louiscryan wrote:
this is not SEVERE. Handlers are expected to throw ProtocolException
and its
subtypes alot, at best this is INFO but probably FINE.
This was actually an artifact of me trying to figure out why eclipse was being stupid. http://codereview.appspot.com/14084/diff/1/9 File java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java (right): http://codereview.appspot.com/14084/diff/1/9#newcode162 Line 162: Map<String, Object> map = Maps.newHashMap(); On 2009/02/12 16:32:35, louiscryan wrote:
JSONObject preserved order of fields, may be a good idea to use
LinkedHashMap to
do the same for readability of the result.
JSONObject uses a HashMap internally. It does not preserve the order of fields. http://codereview.appspot.com/14084
