http://codereview.appspot.com/17086/diff/1/2
File
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java
(right):

http://codereview.appspot.com/17086/diff/1/2#newcode395
Line 395: public MethodCaller(Method method, boolean isRest) throws
NoSuchMethodException {
On 2009/02/19 23:15:35, awiner wrote:
instead of isRest, use an inner enum;  or just pass in
requestItemFirstParamClass;  or just have some statics with the type
signature
of the REST and RPC item constructors, and pass in the whole type
signature
array to the constructor

or add getRestRequestItem and a getRpcRequestItem

http://codereview.appspot.com/17086/diff/1/3
File
java/common/src/test/java/org/apache/shindig/protocol/TestHandler.java
(right):

http://codereview.appspot.com/17086/diff/1/3#newcode103
Line 103: }
add test case for no-param method call

http://codereview.appspot.com/17086

Reply via email to