http://codereview.appspot.com/14109/diff/1/14 File features/features.txt (right):
http://codereview.appspot.com/14109/diff/1/14#newcode23 Line 23: features/opensocial.data/feature.xml opensocial.data and opensocial-data dont mix well. Time for spec cleanup fun! http://codereview.appspot.com/14109/diff/1/27 File features/opensocial.data.activities/activities.js (right): http://codereview.appspot.com/14109/diff/1/27#newcode37 Line 37: opensocial.data.base.ensureAppId(options); why do we need to ensureAppId. It should be inferred from the security token by the receiving server if absent. http://codereview.appspot.com/14109/diff/1/36 File features/opensocial.data.appdata/appdata.js (right): http://codereview.appspot.com/14109/diff/1/36#newcode56 Line 56: ensureFieldsFromKeys(options); dont think we want to do this either. I know this is because of the weirdo REST semantics around PUT but we want to expose the protocol not hide it. Im all for fixing the handling on the backend http://codereview.appspot.com/14109/diff/1/36#newcode70 Line 70: ensureData(options); Do we need to do this. If the caller didnt pass any does the backend break? If so thats a bug on the backend not here. http://codereview.appspot.com/14109/diff/1/36#newcode82 Line 82: var deleteData = function(options) { Naming is odd, if we have conflict with 'delete' because of the reserved keyword then we should use a unified replacement across all services. http://codereview.appspot.com/14109/diff/1/35 File features/opensocial.data.base/jsonrequest.js (right): http://codereview.appspot.com/14109/diff/1/35#newcode56 Line 56: "CONTENT_TYPE" : "JSON", JSON_CONTENT_TYPE instead of "JSON ? http://codereview.appspot.com/14109/diff/1/35#newcode99 Line 99: var defaultUserId = '@viewer'; defaults should live in the protocols and I think they do. http://codereview.appspot.com/14109/diff/1/35#newcode124 Line 124: var normalizeSortAndFilterOptionNames = function(params) { no need to do this any more http://codereview.appspot.com/14109/diff/1/35#newcode133 Line 133: if (options.userId) { protocol accepts one or many I believe as documented http://codereview.appspot.com/14109/diff/1/31 File features/opensocial.data.base/util.js (right): http://codereview.appspot.com/14109/diff/1/31#newcode53 Line 53: opensocial.data.base.translateHttpError = function(httpError) { these should probably be extracted as delimited strings from the error message http://codereview.appspot.com/14109/diff/1/23 File features/opensocial.data.people/people.js (right): http://codereview.appspot.com/14109/diff/1/23#newcode26 Line 26: var defaultFields = ['id', 'displayName']; protocol should handle this http://codereview.appspot.com/14109/diff/1/11 File features/opensocial.data.ui/ui.js (right): http://codereview.appspot.com/14109/diff/1/11#newcode30 Line 30: opensocial.data.ui = function() { Lets discuss turning this into a protocol http://codereview.appspot.com/14109
