Yup, that fixed the problem. :) Cheers, Sean
-----Original Message----- From: Kyle Gordon [mailto:[email protected]] Sent: Friday, 20 February, 2009 1:09 AM To: [email protected] Subject: Re: shindig test build failure I have seen this problem as well. It is a system dependent new line character problem. If you add the following line at line 67 in CSSContentRewriterTest.java the test should pass: expected = expected.replaceAll("\r\n", "\n"); This is obviously not the preferred solution, but it will pass a junit that otherwise should pass. - Kyle On Thu, Feb 19, 2009 at 6:27 AM, Sean Lin <[email protected]> wrote: > Yup, I am running under Vista. > > -----Original Message----- > From: Vincent Siveton [mailto:[email protected]] > Sent: Thursday, 19 February, 2009 8:17 PM > To: [email protected] > Subject: Re: shindig test build failure > > Since Hudson is happy [1] I guess it is a win/unix pb... Sean are you > a win user? > > BTW in the Hudson log, we could see the Throwable exception mentioned > by Sean. Louis, make sense to catch it in Shindig code? > > Cheers, > > Vincent > > [1] > > http://hudson.zones.apache.org/hudson/view/Shindig/job/Shindig/org.apache.sh > indig$shindig-gadgets/350/console<http://hudson.zones.apache.org/hudson/view /Shindig/job/Shindig/org.apache.sh%0Aindig$shindig-gadgets/350/console> > > 2009/2/18, Sean Lin <[email protected]>: > > The following is the output > > > > > > ---------------------------------------------------------------------------- > > --- > > Test set: org.apache.shindig.gadgets.rewrite.CSSContentRewriterTest > > > > ---------------------------------------------------------------------------- > > --- > > Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.201 > sec > > <<< FAILURE! > > > > testCssBasic(org.apache.shindig.gadgets.rewrite.CSSContentRewriterTest) > > > > Time elapsed: 0.142 sec <<< FAILURE! > > junit.framework.ComparisonFailure: null expected:<... fp\3D > 1150739864');[ > > @import > > > url('http\3A// > www.test.com/dir/proxy?url\3Dhttp%3A%2F%2Fwww.example.org%2Fpa<http://www.te st.com/dir/proxy?url%5C3Dhttp%3A%2F%2Fwww.example.org%2Fpa> > > > th%2Frelative%2Fother2.css\26gadget\3Dhttp%3A%2F%2Fwww.example.org > %2Fdir%2Fg > > .xml\26 fp\3D 1150739864'); > > @import url('http\3A//www.example.org/hostrelative/excluded/other1.css'<http://www.e xample.org/hostrelative/excluded/other1.css%27> > ); > > DiV { > > font: arial; > > ] > > }> but was:<... fp\3D 1150739864');[ > > @import > > > url('http\3A// > www.test.com/dir/proxy?url\3Dhttp%3A%2F%2Fwww.example.org%2Fpa<http://www.te st.com/dir/proxy?url%5C3Dhttp%3A%2F%2Fwww.example.org%2Fpa> > > > th%2Frelative%2Fother2.css\26gadget\3Dhttp%3A%2F%2Fwww.example.org > %2Fdir%2Fg > > .xml\26 fp\3D 1150739864'); > > @import url('http\3A//www.example.org/hostrelative/excluded/other1.css'<http://www.e xample.org/hostrelative/excluded/other1.css%27> > ); > > DiV { > > font: arial;] > > }> > > at junit.framework.Assert.assertEquals(Assert.java:81) > > at junit.framework.Assert.assertEquals(Assert.java:87) > > at > > > > org.apache.shindig.gadgets.rewrite.CSSContentRewriterTest.testCssBasic(CSSCo > > ntentRewriterTest.java:68) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39 > > ) > > at > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl > > .java:25) > > at java.lang.reflect.Method.invoke(Method.java:597) > > at junit.framework.TestCase.runTest(TestCase.java:168) > > at junit.framework.TestCase.runBare(TestCase.java:134) > > at junit.framework.TestResult$1.protect(TestResult.java:110) > > at junit.framework.TestResult.runProtected(TestResult.java:128) > > at junit.framework.TestResult.run(TestResult.java:113) > > at junit.framework.TestCase.run(TestCase.java:124) > > at junit.framework.TestSuite.runTest(TestSuite.java:232) > > at junit.framework.TestSuite.run(TestSuite.java:227) > > at > > > > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79 > > ) > > at > > > > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62 > > ) > > at > > > > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(Ab > > stractDirectoryTestSuite.java:140) > > at > > > > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractD > > irectoryTestSuite.java:127) > > at org.apache.maven.surefire.Surefire.run(Surefire.java:177) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39 > > ) > > at > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl > > .java:25) > > at java.lang.reflect.Method.invoke(Method.java:597) > > at > > > > org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireB > > ooter.java:338) > > at > > > > org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:997 > > > > ) > > > > > > > > > > -----Original Message----- > > From: Louis Ryan [mailto:[email protected]] > > > > Sent: Thursday, 19 February, 2009 10:40 AM > > To: [email protected] > > Subject: Re: shindig test build failure > > > > > > That test is passing for me @Head. Can you post the output from the test. > > Look in > > > > java/gadgets/target/surefire-reports/org.apache.shindig.gadgets.rewrite.CSSC > > ontentRewriterTest.txt > > > > On Wed, Feb 18, 2009 at 6:32 PM, Sean Lin <[email protected]> wrote: > > > > > I think you're right. The failure is actually > > > > > > Failed tests: > > > > testCssBasic(org.apache.shindig.gadgets.rewrite.CSSContentRewriterTest) > > > > > > Tests run: 684, Failures: 1, Errors: 0, Skipped: 0 > > > > > > > > > -----Original Message----- > > > From: Louis Ryan [mailto:[email protected]] > > > Sent: Thursday, 19 February, 2009 2:33 AM > > > To: [email protected] > > > Subject: Re: shindig test build failure > > > > > > I think you're seeing a log message from the test that is actually > > > expected. > > > > > > > > > On Wed, Feb 18, 2009 at 1:12 AM, Sean Lin <[email protected]> > wrote: > > > > > > > Hi, > > > > > > > > I'm recently getting a build failure building java shindig. > > > > > > > > > > > > > > > > Throwable: Couldn't read ICC Profile. > > > > > > > > > > > > > > > > What could be wrong? > > > > > > > > > > > > > > > > Cheers, > > > > > > > > Sean > > > > > > > > > > > > > > > > > > > >
