http://codereview.appspot.com/20043/diff/1/5 File features/features.txt (right):
http://codereview.appspot.com/20043/diff/1/5#newcode19 Line 19: features/opensocial-data-base/feature.xml On 2009/02/21 16:00:55, levik wrote:
would "data-store" be a better name? -base conjures up images of SQL
:) Changed to opensocial-data-context http://codereview.appspot.com/20043/diff/1/4 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java (right): http://codereview.appspot.com/20043/diff/1/4#newcode165 Line 165: public void addFeature(String name) { On 2009/02/21 01:37:45, louiscryan wrote:
Gadget is probably a better home for this
Done. http://codereview.appspot.com/20043/diff/1/4#newcode183 Line 183: return ImmutableSet.<String>of(); On 2009/02/21 01:37:45, louiscryan wrote:
Collections.emptySet ?
They're (in essence) the same thing - a shared singleton. I use ImmutableXyz a fair bit, so this is more consistent for me. OTOH, Shindig tends to use Collections.emptySet(), so that's probably better. http://codereview.appspot.com/20043
