http://codereview.appspot.com/23041/diff/3023/2032 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultInvalidationService.java (right):
http://codereview.appspot.com/23041/diff/3023/2032#newcode71 Line 71: public void invalidateApplicationResources(Set<Uri> uris, SecurityToken token) { (Collection<Url> uris, SecurityToken token) should be enough. http://codereview.appspot.com/23041/diff/3023/2032#newcode74 Line 74: httpCache.removeResponse(new HttpRequest(uri)); I think we should mark response as invalid response rather than remove it. So that we can serve stale response when backend is unavailable. http://codereview.appspot.com/23041/diff/3023/2032#newcode83 Line 83: */ To invalidate a user will invalidate all request/response whose owner/viewer is the user. Shall we separate owner from viewer? http://codereview.appspot.com/23041/diff/3023/2040 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java (right): http://codereview.appspot.com/23041/diff/3023/2040#newcode92 Line 92: if (!request.getIgnoreCache()) { If fetchedResponse.isError(), we will cache an error response. http://codereview.appspot.com/23041/diff/3023/2027 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/InvalidationHandler.java (right): http://codereview.appspot.com/23041/diff/3023/2027#newcode72 Line 72: // Assume the the viewer content is being invalidated if it is available Why we need to invalidate viewer by default? http://codereview.appspot.com/23041
