Pan
Can you remove shindig-dev from the codereview issue and add
shindig.remai...@gmail.com instead.
Thanks
-Louis
On Wed, Mar 18, 2009 at 5:15 AM, <panjie....@gmail.com> wrote:
> Reviewers: shindig-dev, chabotc, panjie,
>
> Description:
> This issue is an initial version for limited invalidation. It has not
> been finished yet. I will send another code review when it's ready.
>
> Here're what I did in this patch:
> 1. I added AuthenticationMode, InvalidateService,
> DefaultInvalidateService and InvalidateHandler
> 2. I added AuthType, SecurityToken and invalidation string to
> RemoteContentRequest. Those will be used for checking invalidation.
> 3. I added AuthenticationMode to SecurityToken
>
> TODO items:
> 1. Currently entry point for invalidation is:
> GET /api/rest/invalidate?invalidationKey=xxx
> The final format should be:
> POST /api/rest/invalidate
> Content-Type application/json
> {
> invalidationKeys: {xxx}
> }
> How can I generate such a request with oauth signed?
>
> 2. There is a pitfall about DefaultInvalidationService.
> PHP cache is different from Java. CacheStorageFile will cache http
> request to hard disk. So DefaultInvalidationService::$marker should be
> stored to hard disk too. I will fix it in next patch.
>
> 3. unittests
>
> Please review this at http://codereview.appspot.com/27068
>
> Affected files:
> php/config/container.php
> php/src/common/AuthenticationMode.php
> php/src/common/RemoteContentRequest.php
> php/src/common/SecurityToken.php
> php/src/common/sample/BasicRemoteContent.php
> php/src/common/sample/BasicSecurityToken.php
> php/src/gadgets/GadgetFactory.php
> php/src/gadgets/MakeRequestHandler.php
> php/src/gadgets/oauth/OAuthFetcher.php
> php/src/social/oauth/OAuthSecurityToken.php
> php/src/social/sample/DefaultInvalidateService.php
> php/src/social/service/InvalidateHandler.php
> php/src/social/service/RequestItem.php
> php/src/social/service/RestRequestItem.php
> php/src/social/servlet/ApiServlet.php
> php/src/social/servlet/DataServiceServlet.php
> php/src/social/spi/InvalidateService.php
>
>
>
