It might be nice to have some tests.  java.net.Uri has the following:

http://www.google.com/codesearch/p?hl=en#TTY8xLpnKOE/test/java/net/URI/Test.java&q=java.net.uri%20test%20lang:java


http://codereview.appspot.com/27117/diff/1/2
File java/common/src/main/java/org/apache/shindig/common/uri/Uri.java
(right):

http://codereview.appspot.com/27117/diff/1/2#newcode194
Line 194: Collections.addAll(mergePath, otherPath.split("/"));
Suggest using StringUtils.splitPreserveAllTokens or StringUtils.split
(non-regex).

I *think* preserveAllTokens will avoid the if statement below...

http://codereview.appspot.com/27117

Reply via email to