2009/4/15 Chris Chabot <chab...@google.com>: >> I spoke yesterday with Chris about the make-release.sh: this script >> won't work on my ubuntu box :( > > > Vincent I thought the fix was simple enough:
Yes yes the fix was working perfectly :) > Saying that "it won't work on ubuntu" is a slight over-exaggeration in my > opinion :) Sorry if I offend you, my point was that the out-of-box script needs to be changed depending the platform used for the compilation. > > (i did make a mental note I should probably use /bin/sh though since > according to the FHS that should always be available, but i'll have to > validate that the script works the same on sh first before i can switch that > over) > > Using Maven will be more platform independent, but Chris underlines me >> that the Maven assembly generates a different layout than the >> make-release.sh. >> So I modified the Maven files in r765148 to be align with this script. >> >> @Chris, could you review the generated and confirm that it is the wanted >> layout? >> > > > I also commented that I think this is a "When you have a hammer, everything > looks like a nail" type of solution. > > Most people who use PHP probably won't have a lot of java and maven > knowledge, and are even likely not to even have a working java binary > installed, let alone feeling like installing maven and downloading many Mb's > of dependencies and we really shouldn't force that down people's throats, > not if those tens of megabytes, and different-environment dependencies are > just to solve something that can also be done with 20 lines of shell script. > That just sounds like a solution looking for a problem :) > > Keep in mind that this script could be used to create a release-type-layout > of the directory structure and configuration files by anyone who uses > php-shindig, so the usage of it is far wider then just once to generate a > release tarbal, as such the whole java / mvn dep could only be worth it from > a php perspective if it offered significant benefits over shell script (or > even php based) one.. I guess only Shindig devs could use this script to make a release and (I hope) everybody here has a minimum knowledge of java/maven :) If someone want to make a fork of PHP Shindig, he will probably create its own script to make its release. The script file works perfectly but it is platform dependent which is IMHO bad. We need 2 release managers to create artifacts, and I dont think it is the way to go. If Maven is too bigger, WDYT to use ant? It will be easy to integrate it in the release process. Do we want to centralize build under Maven, for all languages supported and for making release? Cheers, Vincent Note: I am not a PHP dev/user, and I trust your final judgement
