John, maybe there should be an IllegalStateException if Gadget.getAllFeatures() is called without a feature registry attached? I'm concerned this will hide bugs as it's coded here. Alternatively, perhaps getAllFeatures() should take a GadgetFeatureRegistry, to avoid the state dependency?
On Wed, Apr 15, 2009 at 3:35 PM, John Hjelmstad (JIRA) <j...@apache.org>wrote: > > [ > https://issues.apache.org/jira/browse/SHINDIG-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > John Hjelmstad resolved SHINDIG-969. > ------------------------------------ > > Resolution: Fixed > > Patch 4 committed, with one small mod ensuring no NullPointerException > happens if Gadget.getAllFeatures() is called when gadgetFeatureRegistry not > set. > > > Need convenience method to get all required features of a gadget. > > ----------------------------------------------------------------- > > > > Key: SHINDIG-969 > > URL: https://issues.apache.org/jira/browse/SHINDIG-969 > > Project: Shindig > > Issue Type: Improvement > > Components: Java > > Affects Versions: trunk > > Reporter: Balaji Srinivasan > > Priority: Minor > > Fix For: trunk > > > > Attachments: patch.txt, patch2.txt, patch3.txt, patch4.txt > > > > > > Right now if we want to find out all the required features for a gadget, > we have to do the following > > > gadgetFeatureRegistry.getFeatures(gadget.getSpec().getModulePrefs().getFeatures().keySet()) > > This means that any component that needs to get to the list of required > features, has to get access to the gadget feature registry. > > It would be nice to have a convenience method in Gadget that would give > that... > > ie gadget.getAllFeatures(); > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
