Why not just use actual HTTP error codes? I'll personally guarantee that they never change.
On Fri, Apr 17, 2009 at 4:05 PM, Adam Winer <awi...@gmail.com> wrote: > Why is it necessary to make it a class? If we need a few more error > codes, we can add some extra enums. > > If there really is a need to support any HTTP error code and this has > to be a class, there should be some assurance that the built-in HTTP > status codes and jsonValues are not reused - this keeps parsing and > comparisons easy. E.g., UNAUTHORIZED, "unauthorized", and > HttpServletResponse.SC_UNAUTHORIZED all are guaranteed to match up in > all cases. > > On Mon, Apr 13, 2009 at 12:58 PM, <therealsac...@gmail.com> wrote: > > Reviewers: awiner, > > > > Description: > > Changed ResponseError from enum to a class. > > > > https://issues.apache.org/jira/browse/SHINDIG-1012 > > > > Please review this at http://codereview.appspot.com/40076 > > > > Affected files: > > java/common/src/main/java/org/apache/shindig/protocol/ResponseError.java > > > java/common/src/test/java/org/apache/shindig/protocol/ResponseErrorTest.java > > > > > > >
