http://codereview.appspot.com/63214/diff/1/4 File features/src/main/javascript/features/core.io/io.js (right):
http://codereview.appspot.com/63214/diff/1/4#newcode367 Line 367: if (window.oauthReceivedCallbackUrl_) { Why is this being placed in the global scope? It seems to me that the common functionality from oauth popup belongs here, and oauth popup can just add additional behavior for the apps that use it. http://codereview.appspot.com/63214/diff/1/4#newcode369 Line 369: window.oauthReceivedCallbackUrl_ = undefined; For explicit assignment, null is preferred. http://codereview.appspot.com/63214
