Reviewers: shindig.remailer_gmail.com, etnu_google.com, Paul Lindner,
Message:
So it turns out that Twitter returns 403 responses when a client is rate
limited. This causes the oauth proxy to delete oauth tokens. Not
ideal, since the token is still valid.
I'm modifying our code so that tokens are only dropped when we get a 401
response.
This looks safe. I've tested several OAuth service providers, and they
all return 401 on invalid tokens.
Please review this at http://codereview.appspot.com/154105
Affected files:
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthCommandLine.java
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthProtocolException.java
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/testing/MakeRequestClient.java
M
java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java
