http://codereview.appspot.com/186278/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
(right):

http://codereview.appspot.com/186278/diff/1/2#newcode119
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java:119:
encoding = "UTF-8";
Why would we ever receive a request that was not UTF-8 encoded?

http://codereview.appspot.com/186278/diff/1/2#newcode129
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java:129:
req.setPostBody(getParameter(request, POST_DATA_PARAM,
"").getBytes(encoding));
paul lindner ran into nasty performance problems with code like this:

http://paul.vox.com/library/post/the-mysteries-of-java-character-set-performance.html

http://codereview.appspot.com/186278/show

Reply via email to