http://codereview.appspot.com/196053/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
(right):

http://codereview.appspot.com/196053/diff/1/3#newcode462
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java:462:
|| BINARY_CONTENT_TYPES.contains(parts[0])) {
From rfc2616: The type, subtype, and parameter attribute names are case-
insensitive.  Compare parts[0].toLowerCase().

http://codereview.appspot.com/196053/diff/1/3#newcode465
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java:465:
if (parts.length == 2) {
Is there a reason why only the first media type is being checked for a
charset?  For example, 'Content-Type: text/tab-separated-values;
header=present; charset="UTF-8"' is a valid header.

http://codereview.appspot.com/196053/show

Reply via email to