[
https://issues.apache.org/jira/browse/SHINDIG-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erel Segal updated SHINDIG-418:
-------------------------------
Attachment: GadgetDataServlet.patch
This is the first patch I send to Shindig, or to an open source project in
general. Please send me your comments and critics so that I can get better.
> GadgetDataServlet minor efficiency improvement
> ----------------------------------------------
>
> Key: SHINDIG-418
> URL: https://issues.apache.org/jira/browse/SHINDIG-418
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (PHP)
> Reporter: Erel Segal
> Priority: Trivial
> Attachments: GadgetDataServlet.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> a. Added some documentation to the class and functions.
> b. Moved the creation of new RequestItem to just when it is needed - just
> before handling the request.
> c. added a "break" statement after finding a matching handler, since there is
> no need to look further.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
