[
https://issues.apache.org/jira/browse/SHINDIG-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609950#action_12609950
]
Chris Chabot commented on SHINDIG-374:
--------------------------------------
depends, if the 2 are not separated of each other, ie the one change needs the
other, then just include it in one patch.
If their 2 completely different things, then it's good to file a new bug :)
Look forward to seeing the patch!
> Proxy ignores e-tags / if-modified-since
> ----------------------------------------
>
> Key: SHINDIG-374
> URL: https://issues.apache.org/jira/browse/SHINDIG-374
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
>
> The ProxyHandler class does it's own header control instead of using the
> generic Servlet one because it requires full control over what headers are
> send.
> However this currently means it doesn't honor if-modified-since and e-tag
> headers, which causes the proxied files to always be re-downloaded by the web
> browser.
> On straight get's it should really:
> - If if-modified-since is set, and the cached file time is within the
> refreshInterval params value, return not-modified
> - Create it's own e-tag's (md5(responseBody)), and if the e-tag's match
> return a not-modified
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
