[
https://issues.apache.org/jira/browse/SHINDIG-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613738#action_12613738
]
Adam Winer commented on SHINDIG-443:
------------------------------------
- in your pom.xml change. the social-api build can not depend on the gadgets
build and should not depend on the features build. if we need to share any code
it belongs in common.
This definitely does not belong in common. I need some build that depends on
each of social-api, gadgets, and features. I can extract it into a new pom and
new project if you'd rather, but common is "the thing that everyone depends
on", not "the thing that depends on everyone".
- in BasicSecurityTokenDecoder why are you creating a static method? we try to
avoid statics and use guice to inject classes that we can then query. you'll
see that this class is a guice singleton so a non-static method should be fine.
Will do.
- EndToEndModule line 41 - this is bogus. the BeanConverter interface does not
need to be bound. the DataServiceServlet switches between the xml and json
converters by itself. this looks like a bug in the JsonDbOpensocialService
which should really be getting the BeanJsonConverter injected (as opposed to
the BeanConverter)
Agreed, this is bogus. I'll fix JsonDbOpensocialService.
- fetchPersonText.xml - comments should have spaces after // - ie "// Send the
request"
OK.
- overall: it seems really strange to have most of the test function in the
js/xml layer and then have a little java test wrapper class which has to
remember to call the right js functions. can't we make a java test class that
searches for all existing js functions that start with "test" and auto runs
them or something? (the same way that jsunit works). that would be awesomer.
I agree about the strangeness, but don't have a great strategy off the top of
my head. I'd rather think about cleaning that up in a follow-on patch.
> Provide framework for end-to-end testing of RESTful APIs
> --------------------------------------------------------
>
> Key: SHINDIG-443
> URL: https://issues.apache.org/jira/browse/SHINDIG-443
> Project: Shindig
> Issue Type: Test
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Attachments: endtoend.patch
>
>
> I've built a small "framework" for writing end-to-end tests of the RESTful
> APIs, using:
> - GadgetRenderingServlet content
> - OpenSocial 0.8 Javascript
> - DataServiceServlet to handle requests
> - HtmlUnit to tie it together
> A new dependency here is HtmlUnit - it's got an ASF 2.0 license.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
