[ 
https://issues.apache.org/jira/browse/SHINDIG-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614500#action_12614500
 ] 

Cassie Doll commented on SHINDIG-436:
-------------------------------------

This patch definitely improves our caja integration but it doesn't quite work 
for me. The js code looks fine but when I check the "use caja" box the java 
code throws an exception. 

I think I am still going to check this in as the current code path is broken as 
well and this is a step in the right direction. 
Once it is in do you think you can take another look at why it isn't working? I 
will leave this jira open. 

Thanks for your help!

- Cassie

> Code review : caja integration fixes
> ------------------------------------
>
>                 Key: SHINDIG-436
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-436
>             Project: Shindig
>          Issue Type: Task
>          Components: Common Components (Java), Features (Javascript), Gadget 
> Rendering Server (Java), OpenSocial  feature (Javascript)
>            Reporter: Mike Samuel
>         Attachments: shindig-caja-integr.patch
>
>
> The attached patch updates Caja/Shindig integration.
> - Update CajaContentFilter
> - Updated maven dependencies to use the most recent version of caja, and to 
> depend on json_simple separately from caja
> - Fixed bug: sample container ignored checkbox state on first gadget load
> - Added labels to samplecontainer checkboxes so that clicking on the checkbox 
> text activates the checkbox
> - Rewrote enableCaja
> - Modified features/caja/feature.xml to load the runtime javascript support 
> for caja from the jar.  Deleted caja JS files

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to