Something is up since the first patch section tries to patch
EndToEndTest
which doesnt exist,
and then there is a EndToEndTests patch that deletes the whole of
EndToEndTests
If svn mv was used I would have expected to see a full add of
EndToEndTest followed by a full delete of EndToEndTests
I assume you did use svn mv ?
Ian
On 25 Jul 2008, at 00:02, Adam Winer wrote:
I've renamed "EndToEndTests" to "EndToEndTest", as it's going from a
base class for tests to the actual test class. This is the output I'm
getting from one run of svn diff - this isn't a concatenation.
On Thu, Jul 24, 2008 at 3:58 PM, Ian Boston <[EMAIL PROTECTED]> wrote:
Can you have a look at the patch please,
at HEAD
Index:
java/server/src/test/java/org/apache/shindig/server/endtoend/
EndToEndTest.java
===================================================================
---
java/server/src/test/java/org/apache/shindig/server/endtoend/
EndToEndTest.java
(revision 679453)
+++
java/server/src/test/java/org/apache/shindig/server/endtoend/
EndToEndTest.java
(working copy)
Doesnt exist, but the patch applies perfectly to (note Tests.java)
java/server/src/test/java/org/apache/shindig/server/endtoend/
EndToEndTests.java
and then later on in the patch you delete
Index:
java/server/src/test/java/org/apache/shindig/server/endtoend/
EndToEndTests.java
===================================================================
---
java/server/src/test/java/org/apache/shindig/server/endtoend/
EndToEndTests.java
(revision 679551)
+++
java/server/src/test/java/org/apache/shindig/server/endtoend/
EndToEndTests.java
(working copy)
From the version numbers this looks like a concatenation of 2
patches.
Ian
On 24 Jul 2008, at 22:43, Adam Winer (JIRA) wrote:
[
https://issues.apache.org/jira/browse/SHINDIG-473?
page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer updated SHINDIG-473:
-------------------------------
Attachment: shindig-473.patch
Improved end-to-end tests: errors, batching, and fetchPeople
------------------------------------------------------------
Key: SHINDIG-473
URL: https://issues.apache.org/jira/browse/
SHINDIG-473
Project: Shindig
Issue Type: Test
Components: RESTful API (Java)
Reporter: Adam Winer
Attachments: shindig-473.patch
I've beefed up the end-to-end testing framework with some
additions:
- tests of the handling of 400/404/500 responses from the data
service
servlet
- some simple fetchPeople() tests
- a fetchPerson() test that sends a batch
Also, the framework now is capable of expressing "run all the
tests in
file foo.xml", so new tests can be added without writing any .java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
