[ 
https://issues.apache.org/jira/browse/SHINDIG-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henning Schmiedehausen updated SHINDIG-475:
-------------------------------------------

    Attachment: signingfetcherfactory.patch

This patch makes the SigningFetcherFactory more robust and skips lines start 
with - or # so that only data lines are read in. This allows shindig to load 
openssl created certificates directly.

You might want to put a notice somewhere, that the keys must be PKCS8/PEM 
encoded. This might be a big hurdle for people not familiar with crypto.

> SigningFetcherFactory is too naive when reading key files
> ---------------------------------------------------------
>
>                 Key: SHINDIG-475
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-475
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (Java)
>            Reporter: Henning Schmiedehausen
>         Attachments: signingfetcherfactory.patch
>
>
> The current "implementation" of loading PEM files for signing requests will 
> choke on e.g. openssl created files because it tries to parse the  --- BEGIN 
> and --- END lines, too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to