DefaultGuiceModule should validate required properties
------------------------------------------------------

                 Key: SHINDIG-484
                 URL: https://issues.apache.org/jira/browse/SHINDIG-484
             Project: Shindig
          Issue Type: Improvement
            Reporter: Paul Lindner


Before we call 

   Names.bindProperties(this.binder(), properties);

we should do basic validation of the parameters we're injecting.  Currently 
server startup or servlet init will croak
with cryptic error messages if the appropriate parameters are not specified.

For example I spent a few hours with this error:

SEVERE: Allocate exception for servlet xml-to-html
com.google.inject.ConfigurationException: Error at 
org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.setGadgetRenderer(GadgetRenderingServlet.java:38)
 Binding to 
com.google.inject.Provider<org.apache.shindig.gadgets.servlet.GadgetRenderingTask>
 not found. No bindings to that type were found.


And this was actually caused by a missing String binding for "features.default" 
for GadgetFeatureRegistry

  public GadgetFeatureRegistry(@Named("features.default") String featureFiles,



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to