[
https://issues.apache.org/jira/browse/SHINDIG-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618638#action_12618638
]
impetus technologies commented on SHINDIG-477:
----------------------------------------------
Hi Chris,
The first patch had a minor issue.It throws an exception,in case private.key
file does not exists in the certs folder.Have fixed this issue now.The fix is
attached. Please consider this
> SigningFetcherFactory was not working properly
> ----------------------------------------------
>
> Key: SHINDIG-477
> URL: https://issues.apache.org/jira/browse/SHINDIG-477
> Project: Shindig
> Issue Type: Bug
> Environment: Windows
> Reporter: impetus technologies
> Attachments: SigningFetcherFactory.php.patch,
> SigningFetcherFactory.php.patch
>
>
> In SigningFetcherFactory.php the code was written to read private.key file
> which is not there in "cert" folder by default, that's why it was throwing
> exception and not rendering the gadget. Even if a proper key file is placed
> in the cert folder then code is setting cache before
> openssl_pkey_get_private() call, as per my opinion cache must be set after
> the method call.Have done couple of changes to address this. Patch is
> attached. Pls validate.
> P.S: Found this issue, while exceuting a Oauth gadget in samplecontainer
> - Ram Sharma
> Impetus Infotech
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
