[
https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-492.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Ahh right we should indeed remove that configuration key, thanks for the hint.
However you can customize your options quite easily, the system scans the
'container_path' folder for all *.js files, and loads them all in..
The default container.js contains the default configuration (which you
shouldn't modify, as you point out it will be updated when you pull down
updates from svn).
However if you copy container.js to 'foo.js' and then change :
{"gadgets.container" : ["default"],
to
{"gadgets.container" : ["foo"],
at the top of the file. Or create an empty file that contains:
{"gadgets.container" : ["foo"],
// my-custom-settings-go-here
}
you can make any adjustments there you want too, which will be applied when the
container=foo is set.
How it works is that the ContainerConfig class checks the container param + the
config key your looking for, and if there is a container specific config
setting for it, it uses that one, and otherwise the default value.
This way you can have a lot of different container configurations, and only
modify the settings required for those containers... quite a bit more flexible
then the original container_config system (which was never really used in
practice)
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other
> config file instead of container.js. However when GadgetContext creates
> ContainerConfig instance in instanceContainerConfig method, it uses
> "container_path" option for initialization, thus javascript options are
> always loaded from /shindig/config/container.js file. This file can be
> overwritten during shindig update, thus it's not a good idea to customize it,
> so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
