[ 
https://issues.apache.org/jira/browse/SHINDIG-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622384#action_12622384
 ] 

Brian Eaton commented on SHINDIG-346:
-------------------------------------

Thanks for the patch Reema.

We should find a way to reuse the html_sanitize function without cutting and 
pasting the code into util.js.  The Caja code in Shindig has recently been 
redone, but I think you can reference features/caja/feature.xml for an example 
of how to pull source out of caja.  Something like this, maybe?

    <script src="res:///com/google/caja/plugin/html-sanitizer.js"></script>

The bigger issue is the lack of URL sanitization.  If a gadget author calls 
sanitizeHtml, they should be guaranteed that the resulting HTML snippet 
contains no script.  Something like <a href="javascript:..."> should not be 
possible.

Would you be willing to work on the URL sanitization part while I try to track 
down someone who with a long term vision about how Caja and Shindig should 
share code to help with the other piece?


> Implement gadgets.util.sanitizeHtml
> -----------------------------------
>
>                 Key: SHINDIG-346
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-346
>             Project: Shindig
>          Issue Type: Sub-task
>            Reporter: Kevin Brown
>            Assignee: Brian Eaton
>         Attachments: fix-346-bug.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to