[
https://issues.apache.org/jira/browse/SHINDIG-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-514.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Thanks, nice suggestion. Patch has been applied & committed.
Ps, it's good form to declare the class var before using it, it takes the away
the auto magic and puts design and intend in it's place :)
> Reduce Config::get usage in BasicBlobCrypter to simplify overriding
> -------------------------------------------------------------------
>
> Key: SHINDIG-514
> URL: https://issues.apache.org/jira/browse/SHINDIG-514
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: reduce_config_usage.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Currently BasicBlobCrypter uses Config::get('allow_plaintext_token') in it's
> wrap/unwrap implementation. If this value is moved to __construct, it becomes
> easier to create custom BlobCrypter by overriding only __construct method in
> child class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
