[
https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625070#action_12625070
]
Artemy Tregubenko commented on SHINDIG-528:
-------------------------------------------
Nice, thanks! Hope you'll also remove that nasty 'require' and change private
access to configurable properties to protected : )
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in
> unicode-compatible mode. However it's not very good when strings are used as
> byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus
> are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for
> overridable config variables, removal of require of Crypto in
> BasicBlobCrypter, as it's autoloadable but may be not available at given
> path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
