[
https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625784#action_12625784
]
Louis Ryan commented on SHINDIG-478:
------------------------------------
David,
I took a quick look through and the code looks very clean so Im happy to apply
this patch mostly as is.
A couple of notes...
- there are no unit tests and no sample test gadget. Are you guys at the point
where a gadget rendered in the samplecontainer using this feature could do
something useful? We have an EndToEnd test that uses HTML unit which may
sufficiently simulate a browser environment for you to use, certainly worth a
look.
- feature.xml - I would definitely put a comment that serving JS files from
googlecode is for testing only and should never be used in a production
setting. Im assuming it convenient to do this at the moment but the files will
need to be checked into Shindig svn when you have a stable version or
containers should host them independently.
- no files in Shindig have authorship comments, I personally think its OK for
TODOs to have people linked to them but we haven't been doing that either.
base.js
42: Should use same pattern of var opensocial = opensocial || {} instead of
window.opensocial. I see a couple of different variations of gadgets,
window.gadgets & window["gadgets"]. Was there some compiler you guys were
trying to make happy?
82: onlyWhitespace: /^[ \n]*$/ - This is only matching space and newline, no
tabs?
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the
> proposal for OpenSocial Templates
> (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com.
> Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard
> tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
