[
https://issues.apache.org/jira/browse/SHINDIG-539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-539.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Patch committed, very nice feeling to have one blocker issue out of the way
already!
Response format looks good to me too:
<?xml version="1.0" encoding="UTF-8"?>
<response>
<person>
<isOwner></isOwner>
<isViewer></isViewer>
<name>
<familyName>Chabot</familyName>
<givenName>Chris</givenName>
<unstructured>Chris Chabot</unstructured>
</name>
<id>1</id>
<thumbnailUrl>http://www.partuza.nl/images/people/1.96x96.jpg</thumbnailUrl>
<profileUrl>http://www.partuza.nl/profile/1</profileUrl>
</person>
</response>
Oh ps in the OutputXmlConverter::outputResponse() function i noticed these:
$userId = $requestItem->getUser()->getUserId($requestItem->getToken());
$endPos = ($startIndex + $itemsPerPage) > $totalResults ? $totalResults :
($startIndex + $itemsPerPage);
$idField = is_object($response) && isset($response->id) ? $response->id :
(is_array($response) && isset($response['id']) ? $response['id'] :
$requestItem->getUser()->getUserId($requestItem->getToken()));
But $userId isn't used in the XML format (was there for filling in the author
field in the atom version), same goes for the other 2 var definitions. Nothing
major but much cleaner not to have unused code in there :)
> Add format=XML support
> ----------------------
>
> Key: SHINDIG-539
> URL: https://issues.apache.org/jira/browse/SHINDIG-539
> Project: Shindig
> Issue Type: New Feature
> Components: RESTful API (PHP)
> Reporter: Chris Chabot
> Assignee: Chris Chabot
> Priority: Blocker
> Attachments: InputXmlConverter.php, OutputXmlConverter.php,
> RestServlet.php.patch
>
>
> Add &format=xml support to the RESTful interface. See
> http://docs.google.com/View?docid=dcc2jvzt_37hdzwkmf8 for details
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
