I think it might not be a performance impact to the social data server, since it will only apply the detection process to those requests, which doesn't indicate its char encoding.
On Sat, Sep 6, 2008 at 7:02 AM, Kevin Brown (JIRA) <[EMAIL PROTECTED]> wrote: > > [ > https://issues.apache.org/jira/browse/SHINDIG-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628788#action_12628788] > > Kevin Brown commented on SHINDIG-487: > ------------------------------------- > > We actually do perform encoding detection if there's no other way to figure > out the encoding, but that's because we have to support wonky legacy HTTP > servers. There's no valid reason why the social data code should be forced > to do this, however. Callers that don't use utf-8 can just tell us what > encoding they are using. > > To reiterate, I'm strongly against doing the encoding detection here. > > > Fix encoding bugs > > ----------------- > > > > Key: SHINDIG-487 > > URL: https://issues.apache.org/jira/browse/SHINDIG-487 > > Project: Shindig > > Issue Type: Bug > > Components: RESTful API (Java) > > Environment: Windows XP, China as region, Chinese as prefer > language > > Reporter: Jacky Wang > > Attachments: fix-java-input-encoding-detection-bug.patch, > fix-socialapi-post-unicode-bug.patch, fix-socialapi-post-unicode-bug.patch > > > > Original Estimate: 0.25h > > Remaining Estimate: 0.25h > > > > For the input requests, we can't pre-determine its character encoding, > thus we need to parse the input according to HttpServletRequest. > > If the HttpServletRequest doesn't have this header, we'll use "UTF-8" as > default value. > > For all outbound response, since they're under Shindig's control, we'll > set their CharacterEncoding to "UTF-8". > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- Best Regards, Jacky Wang +86-10-6250-3316 +86-1381-0018-677 [EMAIL PROTECTED]
