The issue is correct. The difficulty is sharing JS and EndToEnd tests between the Java and PHP implementations. While not ideal we should not reject useful patches in Java because we don't have an equivalent yet in PHP. They can always be refactored later when a suitable harness exists in PHP to share as much code as possible.
On Thu, Sep 11, 2008 at 3:07 PM, Kevin Jin (JIRA) <[EMAIL PROTECTED]> wrote: > > [ > https://issues.apache.org/jira/browse/SHINDIG-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630396#action_12630396] > > Kevin Jin commented on SHINDIG-585: > ----------------------------------- > > features/opensocial-templates uses some browser-provided objects (like > document and window), therefore cannot be run in jsunit.berlios.deplug-in. > I find some tests can be run in HtmlUnit. I think it'd be nice to have some > automated tests that can be run within Maven, so I created this patch. > I also have gadget tests that will submit to opensocial-resources project, > just like the compliance tests. But they are not automated. You have to load > them into a browser. > If this patch is not suitable, please close this issue because HtmlUnit is > the only automation solution available in Shindig. > > > OpenSocial template tests need to be automated > > ---------------------------------------------- > > > > Key: SHINDIG-585 > > URL: https://issues.apache.org/jira/browse/SHINDIG-585 > > Project: Shindig > > Issue Type: Bug > > Reporter: Louis Ryan > > Attachments: fix-585.patch > > > > > > we need some % of the tests to be executable automatically > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
