[ 
https://issues.apache.org/jira/browse/SHINDIG-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634192#action_12634192
 ] 

Cassie Doll commented on SHINDIG-611:
-------------------------------------

It looks great and I'm committing it now. 
Just a few style things:

- missing license header on BeanAtomConverter
- a bunch of the files had tabs in them instead of just spaces. i fixed them 
all but you might want to check your ide/text editor settings
- watch order of imports - ApiServlet and maybe some others had shindig imports 
at the bottom
- I renamed BeanAtomConvertor to be BeanAtomConverter (ie ends in er) to match 
the others we have
- watch spaces after commas in lists of parameters. ie do "cat, dog" instead of 
"cat,dog"

Thanks!

> Add format=XML support
> ----------------------
>
>                 Key: SHINDIG-611
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-611
>             Project: Shindig
>          Issue Type: New Feature
>          Components: RESTful API (Java)
>            Reporter: impetus technologies
>            Priority: Blocker
>         Attachments: shindigpatch611.patch
>
>
> Add &format=xml support to the RESTful interface. See 
> http://docs.google.com/View?docid=dcc2jvzt_37hdzwkmf8 for details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to