[
https://issues.apache.org/jira/browse/SHINDIG-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634861#action_12634861
]
Kevin Brown commented on SHINDIG-466:
-------------------------------------
This isn't a problem of substitution ordering, it's that substitution for
UserPref elements needs to be done be before any other substitution (object
order, not operation order is wrong).
> Wrong sequence of substitutions in GadgetServer
> -----------------------------------------------
>
> Key: SHINDIG-466
> URL: https://issues.apache.org/jira/browse/SHINDIG-466
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (Java)
> Environment: any
> Reporter: christof kaleschke
>
> When the substitutions take place in the method
> GadgetServer.createGadgetFromSpec() this is done in the sequence: MESSAGE,
> BIDI, USERPREF, MODULE. This sequence leads to wrong substitutions in the
> following (complicated) case:
> If the default_value attribute of a <UserPref> element contains a __MSG
> value and a <ModulePrefs> attribute or subelement references this <UserPref>
> element via __UPit is substituted to the __MSG value and not to the element
> from the message bundle.
> Take the example: http://www.google.com/ig/modules/youtube_videos.xml. There
> the UserPref channel_url_to_preload contains the default_value
> __MSG_recently_featured_rss__. A Preload element references this UserPref via
> __UP_channel_url_to_preload__ in its href attribute. After the substitutions
> in GadgetServer.createGadgetFromSpec() the value in the href attribute is
> __MSG_recently_featured_rss__ and not
> "http://youtube.com/rss/global/recently_featured.rss"; from the message bundle.
> I think the sequence of substitutions should be: USERPREF, MESSAGE, BIDI,
> MODULE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
