[
https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636337#action_12636337
]
Ian Boston commented on SHINDIG-638:
------------------------------------
Patch looks good, apart from one tailing space area.
So fixed that and applied, thanks.
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet
> uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends
> DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
