[
https://issues.apache.org/jira/browse/SHINDIG-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639076#action_12639076
]
Chris Chabot commented on SHINDIG-653:
--------------------------------------
There were 3 major changes to the SPI:
1) All return types are now plain var's and array's and response items are
*not* used in the service layer anymore.. this patch didn't update that yet
2) All error conditions are now supposed to be SocialSpiException's (in the
format of: throw new SocialSpiException("Invalid create activity request:
".$e->getMessage(), ResponseError::$INTERNAL_ERROR)), that's also missing in
this patch.
3) Some logic changes in the way that the params are dealt with, you updated
the idSpec changes (which was completely required) but a couple of other
changes you missed I think.
It's a good start though and a lot better then the completely broken code we
had, so i'll commit the work so far, but if you do feel up for it (and your
work on this is really incredibly appreciated!) could you address the other
required changes too? Having a working out-of-the-box experience again would be
awesome
> Can't retrieve the people resources with @all and etc
> -----------------------------------------------------
>
> Key: SHINDIG-653
> URL: https://issues.apache.org/jira/browse/SHINDIG-653
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (PHP)
> Reporter: Yoichiro Tanaka
> Assignee: Chris Chabot
> Attachments: fix-653.patch, JsonDbOpensocialService.php.patch
>
>
> PHP Fatal error occurs at retrieving the people resources with @all,
> @friends, and etc. For example, if we try to access to the following url:
> http://my.server.host/social/rest/people/john.doe/@all
> then the error like the following is written in error_log:
> [Sun Oct 12 11:56:18 2008] [error] [client ::1] PHP Fatal error: Call to a
> member function getUserId() on a non-object in
> /Library/WebServer/Documents/shindig_alone/php/src/social/sample/JsonDbOpensocialService.php
> on line 206
> This cause is that the array which includes the userId object is passed as
> the first argument for calling getPeople() function. However, the userId
> object is expected in getPeople(), not the array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
