[
https://issues.apache.org/jira/browse/SHINDIG-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648932#action_12648932
]
Chris Chabot commented on SHINDIG-452:
--------------------------------------
Hey Erel,
These patches are really amazing, however sadly i'm getting to many conflicts
while trying to apply them, we've had such deep code restructering preparing
for full 0.8.1 support and getting ready for the 1.0 release that a lot of
things moved.
If you do have the time to re-do the patch based on the current svn trunk, I
would be more then happy to apply it right away!
> documentation additions
> -----------------------
>
> Key: SHINDIG-452
> URL: https://issues.apache.org/jira/browse/SHINDIG-452
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Reporter: Erel Segal
> Attachments: documentation.patch, GadgetSpecParser.php
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> While reading the code, I added lots of documentation, both outside functions
> (in phpdoc format) and inside functions. I think this might help other new
> programmers get into the code.
> NOTE: For some reason, the patch for file GadgetSpecParser.php seems like
> removing all lines and writing a new version, this is probably a problem in
> my SVN client diff mechanizm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
