[
https://issues.apache.org/jira/browse/SHINDIG-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648950#action_12648950
]
Chris Chabot commented on SHINDIG-306:
--------------------------------------
the patch still removes this code:
- //TODO: The samplecontainer doesn't support any filters yet. We
should fix this.
- $totalSize = count($people);
- $last = $first + $max;
- $last = min($last, $totalSize);
- if ($first !== false && $first != null && $last) {
- $people = array_slice($people, $first, $last);
- }
in your patch the first/max is only applied if there is a name or topFriends
sort order specified, but the orignal code is correct and shouldn't be removed.
This was mentioned in an earlier comment too... could you please see about
fixing it?
And please remove the outdated files attached to the patch :)
> 0.8 -- Add topFriends filter
> ----------------------------
>
> Key: SHINDIG-306
> URL: https://issues.apache.org/jira/browse/SHINDIG-306
> Project: Shindig
> Issue Type: New Feature
> Components: RESTful API (PHP)
> Reporter: Paul Lindner
> Assignee: Paul Lindner
> Attachments: BasicPeopleService.php.patch, canonicaldb.json.patch,
> getTopFriends.xml, JsonDbOpensocialService.php.patch,
> state-basicfriendlist.xml.patch, XmlStateFileFetcher.php.patch
>
>
> ref: FILTER_TYPE-001
> Top friends should be a filter as well as a sort...
> opensocial.DataRequest.FilterType = {
> /**
> * Retrieves only the user's top friends.
> *
> * @member opensocial.DataRequest.FilterType
> */
> TOP_FRIENDS : 'topFriends',
> ...
> } Top friends should be a filter as well as a sort
> http://groups.google.com/group/opensocial-and-gadgets-spec/browse_thread/thread/ae406a39198ecd31
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
