[
https://issues.apache.org/jira/browse/SHINDIG-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-631.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
There was a debug statement left in the patches:
echo $fieldValue."-----".$filterValue."!!!!!";
please double check for those kind of things before submitting a patch please :)
Also, it would really make things easier for me if you could put all the
patches into one file (instead of 3 seperate ones) with a proper base path. Now
I have to hunt down each file, cd into the folder, and apply the
single-patch-by-file.
If you could do a :
# cd shindig/php
# svn diff > FixesMyProblem.patch
The the base of the patch entries would be something like "Index:
src/social/foo/bar.php", which means I can just apply it without any tracking
down files :)
For the rest the patch looks good to me, applied and committed, thanks!
> get Activities filter by fields
> -------------------------------
>
> Key: SHINDIG-631
> URL: https://issues.apache.org/jira/browse/SHINDIG-631
> Project: Shindig
> Issue Type: New Feature
> Components: RESTful API (PHP)
> Environment: Windows, Apache
> Reporter: impetus technologies
> Assignee: Chris Chabot
> Attachments: ActivityHandler.php.patch, ActivityService.php.patch,
> JsonDbOpensocialService.php.patch
>
>
> Hi,
> "Activities-filter by fields" feature is not implemented in current
> SHINDIG-PHP. I have implemented it.
> There was another issue that
> "social/rest/activities/userId/groupId/activityId" was not working with
> current code. I have also correct that.
> Patches are attached. Pls verify them
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
