[ 
https://issues.apache.org/jira/browse/SHINDIG-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652316#action_12652316
 ] 

Louis Ryan commented on SHINDIG-718:
------------------------------------

It would seem more consistent to always bind an instance of ProxySelector 
rather than Provider<Proxy> and then use

List<Proxy> proxies = selector.select(url.toURI());
if (proxies.isEmpty()) {
 ...  url.openConnection();
} else {
  ... url.openConnection(proxies.get(0));
}

not sure but if select always returns a non empty list then the if-else can be 
simplified. 



> Building shindig from behind a proxy fails
> ------------------------------------------
>
>                 Key: SHINDIG-718
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-718
>             Project: Shindig
>          Issue Type: Bug
>          Components: Common Components (Java)
>         Environment: Behind a proxy
>            Reporter: Chico Charlesworth
>         Attachments: fix-proxy-bug.patch
>
>
> When the maven build runs behind a proxy the test 
> EndToEndTest.testTemplates() fails.
> i.e. mvn clean install -Dhttp.proxyHost=<host> -Dhttp.proxyPort=<port>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to