[
https://issues.apache.org/jira/browse/SHINDIG-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654041#action_12654041
]
Ben Smith commented on SHINDIG-767:
-----------------------------------
Kevin, you're right, the default configuration will continue to be used by
Shindig, there's no other way.
However, for people developing their own intergrations (such as myself),
creating this alternative constructor means that we, in our own new Guice
modules, can call 'this.install( new PropertiesModule(filePath) );' and
additionally can use it from within tests and such like.
Duplicating this code in everyone elses projects, while not a big deal, just
seems a bit unnecessary.
The PropertiesModule could be altered to provide a consistent interface for the
loading of properties files under certain conditions (put in the right place,
with the right prefix, with the wind blowing in the right direction) but I
think this will be plenty for now.
> PropertiesModule should be able to property files other than the default
> ------------------------------------------------------------------------
>
> Key: SHINDIG-767
> URL: https://issues.apache.org/jira/browse/SHINDIG-767
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Affects Versions: trunk
> Environment: osx
> Reporter: Ben Smith
> Priority: Minor
> Fix For: trunk
>
> Attachments: fix-767-723685-improvement.patch
>
>
> org.apache.shindig.common.PropertiesModule currently will only read
> properties in from the shindig.properties file. It would be useful to be able
> to have the PropertiesModule be able to read in other properties files so as
> not to duplicate.
> Clearly the module's primary use is to load shindig.properties, and this
> should continue to work, especially when called in a web.xml. However, it
> would be useful to be able to construct the module with a different property
> file for intergrating developers.
> Patch will be provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
