[ 
https://issues.apache.org/jira/browse/SHINDIG-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yoichiro Tanaka resolved SHINDIG-647.
-------------------------------------

    Resolution: Invalid

I change this issue to invalid because my proposal was not accepted.

> Adding gadgets.views.View#checkType() function
> ----------------------------------------------
>
>                 Key: SHINDIG-647
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-647
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Features (Javascript)
>            Reporter: Yoichiro Tanaka
>         Attachments: add-checkType-method.patch
>
>
> I have propose to add gadgets.views.View#checkType() function. This proposal 
> is written in following entry:
> http://groups.google.com/group/opensocial-and-gadgets-spec/browse_thread/thread/e4896bbdf6e5626
> ---
> In some containers based on apache shindig, the result of the
> gadgets.views.View#getName() function is not equal to the constant
> value defined by gadgets.views.ViewType class. In particular, the
> result of the gadgets.views.View#getName() on the canvas view is
> "canvas" written in the config/container.js file, and the constant
> value of ViewType.CANVAS is defined as "CANVAS" in the features/views/
> views.js file.
> Therefore, in current version of opensocial, we cannot confirm which
> view type is this view using getName() function. But, fortunately, it
> will be able to ensure that "CANVAS" and "canvas" is same, because
> each view can have some aliases.
> My proposal is to add the following function for checking view type. 
> ---
> I made this implementation. Please commit this patch if this proposal is 
> accepted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to