[
https://issues.apache.org/jira/browse/SHINDIG-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658013#action_12658013
]
Kevin Brown commented on SHINDIG-805:
-------------------------------------
This sounds like a good idea. A couple of comments on the patch:
- Brace alignment doesn't match shindig style in some places.
- import order is inconsistent (we normally group shindig imports, then
alphabetical third party, then java / javax).
- I think we can stop injecting ContainerConfig into RenderingContentRewriter
entirely with this addition. A ConfigurationContributor can take care of
everything that's happening in the rewriter now. This keeps
RenderingContentRewriter's dependencies to a minimum.
Other than that, this looks good to me.
> Modularize contributors to gadgets.config.init and make them injectable
> -----------------------------------------------------------------------
>
> Key: SHINDIG-805
> URL: https://issues.apache.org/jira/browse/SHINDIG-805
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Affects Versions: 1.0.x-incubating
> Reporter: Henning Schmiedehausen
> Attachments: SHINDIG-805
>
>
> In the RenderingContentRewriter, some content of the gadget.config.init is
> generated on the Java side and then injected to Javascript (i.e. it is not
> pulled from the features registered). This currently is the feature
> configuration for core.util (which has another bug, see SHINDIG-803) and the
> shindig.auth creation. Both of these are hard coded.
> In our use case, we need to contribute additional fields for platform
> specific configuration elements, which is best done on the Java core side.
> This patch pulls out the two pieces into ConfigContributors and makes these
> configureable and injectable through Guice, thus allowing integrators to add
> their own Contributors without having to patch the Shindig code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
